Dylan/excalidraw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Lint fix, comment fix

Browse Source
This commit is contained in:
Marcel Mraz 2024-02-08 10:05:58 +01:00
parent 8a06b70588
commit f16967fc52
2 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/excalidraw/element/resizeElements.ts
View File

@ -52,8 +52,6 @@ import {
handleBindTextResize, handleBindTextResize,
getBoundTextMaxWidth, getBoundTextMaxWidth,
getApproxMinLineHeight, getApproxMinLineHeight,
measureText,
getBoundTextMaxHeight,
} from "./textElement"; } from "./textElement";
import { LinearElementEditor } from "./linearElementEditor"; import { LinearElementEditor } from "./linearElementEditor";

15
packages/excalidraw/renderer/renderElement.ts
View File

@ -397,19 +397,16 @@ const drawElementOnCanvas = (
); );
const metrics = context.measureText(element.text); const metrics = context.measureText(element.text);
// TODO_DOMLESS: we shouldn't need the harcoded line-heights as now with line gaps we could have any line-height (double-check)
const lineGap = const lineGap =
(lineHeightPx - lineHeightPx -
(metrics.fontBoundingBoxAscent + metrics.fontBoundingBoxDescent)) / (metrics.fontBoundingBoxAscent + metrics.fontBoundingBoxDescent);
2;
/** /**
* Set a vertical offset to be aligned with <textarea>. * Set a vertical offset to be aligned with <textarea>.
* - `fontBoundingBoxAscent` is here the default "gap" for the font with its default line-height used in textareas * - `fontBoundingBoxAscent` is here the font bouding box with its default line-height used in textareas
* - line gap is the padding above and below font bounding box to be consistent regardless of the default font line-height * - half of the line gap is the additional padding above and below the bounding box when line-height isn't equal to the default value
* - for details check https://codesandbox.io/p/devbox/v4nsqz?file=%2Fsrc%2Findex.js%3A1%2C1-166%2C1 * - for details check - https://codesandbox.io/p/devbox/v4nsqz?file=%2Fsrc%2Findex.js%3A1%2C1-166%2C1
*/ */
context.translate(0, metrics.fontBoundingBoxAscent + lineGap); context.translate(0, metrics.fontBoundingBoxAscent + lineGap / 2);
for (let index = 0; index < lines.length; index++) { for (let index = 0; index < lines.length; index++) {
context.fillText( context.fillText(