From bcb45f7cf6661e2a6ddee1c06600c48e50e905a3 Mon Sep 17 00:00:00 2001
From: Aakansha Doshi <aakansha1216@gmail.com>
Date: Wed, 24 Aug 2022 15:49:04 +0530
Subject: [PATCH] fix: hide points outside linear element editor when close
 enough

---
 src/element/linearElementEditor.ts | 32 ++++++++++++++++++++++++++
 src/renderer/renderScene.ts        | 37 +++++++++++++++++-------------
 2 files changed, 53 insertions(+), 16 deletions(-)

diff --git a/src/element/linearElementEditor.ts b/src/element/linearElementEditor.ts
index 48972a823..900c4a1e9 100644
--- a/src/element/linearElementEditor.ts
+++ b/src/element/linearElementEditor.ts
@@ -409,6 +409,38 @@ export class LinearElementEditor {
     return centerPoint(points[0], points.at(-1)!);
   }
 
+  static getVisiblePointIndexes(
+    linearElementEditor: LinearElementEditor,
+    appState: AppState,
+  ) {
+    const { elementId } = linearElementEditor;
+    const element = LinearElementEditor.getElement(elementId);
+    if (!element) {
+      return [];
+    }
+    const visiblePointIndexes: number[] = [];
+    let previousPoint: Point | null = null;
+    element.points.forEach((point, index) => {
+      let distance = Infinity;
+      if (previousPoint) {
+        distance = distance2d(
+          point[0],
+          point[1],
+          previousPoint[0],
+          previousPoint[1],
+        );
+      }
+      if (
+        (!appState.editingLinearElement &&
+          distance >= 2 * LinearElementEditor.POINT_HANDLE_SIZE) ||
+        appState.editingLinearElement
+      ) {
+        visiblePointIndexes.push(index);
+        previousPoint = point;
+      }
+    });
+    return visiblePointIndexes;
+  }
   static handlePointerDown(
     event: React.PointerEvent<HTMLCanvasElement>,
     appState: AppState,
diff --git a/src/renderer/renderScene.ts b/src/renderer/renderScene.ts
index 8ac1e1ab7..a5ba40368 100644
--- a/src/renderer/renderScene.ts
+++ b/src/renderer/renderScene.ts
@@ -159,7 +159,6 @@ const strokeGrid = (
 
 const renderSingleLinearPoint = (
   context: CanvasRenderingContext2D,
-  appState: AppState,
   renderConfig: RenderConfig,
   point: Point,
   radius: number,
@@ -207,18 +206,16 @@ const renderLinearPointHandles = (
   const radius = appState.editingLinearElement
     ? POINT_HANDLE_SIZE
     : POINT_HANDLE_SIZE / 2;
-  points.forEach((point, idx) => {
-    const isSelected =
-      !!appState.editingLinearElement?.selectedPointsIndices?.includes(idx);
 
-    renderSingleLinearPoint(
-      context,
-      appState,
-      renderConfig,
-      point,
-      radius,
-      isSelected,
-    );
+  const visiblePointIndexes = LinearElementEditor.getVisiblePointIndexes(
+    appState.selectedLinearElement,
+    appState,
+  );
+  visiblePointIndexes.forEach((index) => {
+    const isSelected =
+      !!appState.editingLinearElement?.selectedPointsIndices?.includes(index);
+    const point = points[index];
+    renderSingleLinearPoint(context, renderConfig, point, radius, isSelected);
   });
 
   if (points.length < 3) {
@@ -233,7 +230,6 @@ const renderLinearPointHandles = (
       if (appState.editingLinearElement) {
         renderSingleLinearPoint(
           context,
-          appState,
           renderConfig,
           centerPoint,
           radius,
@@ -244,7 +240,7 @@ const renderLinearPointHandles = (
         highlightPoint(centerPoint, context, renderConfig);
         renderSingleLinearPoint(
           context,
-          appState,
+
           renderConfig,
           centerPoint,
           radius,
@@ -254,7 +250,6 @@ const renderLinearPointHandles = (
     } else {
       renderSingleLinearPoint(
         context,
-        appState,
         renderConfig,
         centerPoint,
         POINT_HANDLE_SIZE / 2,
@@ -441,7 +436,17 @@ export const _renderScene = ({
       appState.selectedLinearElement &&
       appState.selectedLinearElement.hoverPointIndex >= 0
     ) {
-      renderLinearElementPointHighlight(context, appState, renderConfig);
+      const visiblePointIndexes = LinearElementEditor.getVisiblePointIndexes(
+        appState.selectedLinearElement,
+        appState,
+      );
+      if (
+        visiblePointIndexes.includes(
+          appState.selectedLinearElement.hoverPointIndex,
+        )
+      ) {
+        renderLinearElementPointHighlight(context, appState, renderConfig);
+      }
     }
     // Paint selected elements
     if (