Dylan/excalidraw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Optimize frameToHighlight state change and snapLines state change (#8763)

Browse Source 
Fix case when frame interactions recursively call setState() without any change.
This commit is contained in:
Márk Tolmács 2024-11-21 15:19:00 +01:00 committed by GitHub
parent d21e0008dd
commit ab8b3537b3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/excalidraw/components/App.tsx
View File

@ -7940,10 +7940,14 @@ class App extends React.Component<AppProps, AppState> {
isFrameLikeElement(e), isFrameLikeElement(e),
); );
const topLayerFrame = this.getTopLayerFrameAtSceneCoords(pointerCoords); const topLayerFrame = this.getTopLayerFrameAtSceneCoords(pointerCoords);
this.setState({ const frameToHighlight =
frameToHighlight: topLayerFrame && !selectedElementsHasAFrame ? topLayerFrame : null;
topLayerFrame && !selectedElementsHasAFrame ? topLayerFrame : null, // Only update the state if there is a difference
if (this.state.frameToHighlight !== frameToHighlight) {
flushSync(() => {
this.setState({ frameToHighlight });
}); });
}
// Marking that click was used for dragging to check // Marking that click was used for dragging to check
// if elements should be deselected on pointerup // if elements should be deselected on pointerup
@ -8090,7 +8094,9 @@ class App extends React.Component<AppProps, AppState> {
this.scene.getNonDeletedElementsMap(), this.scene.getNonDeletedElementsMap(),
); );
flushSync(() => {
this.setState({ snapLines }); this.setState({ snapLines });
});
// when we're editing the name of a frame, we want the user to be // when we're editing the name of a frame, we want the user to be
// able to select and interact with the text input // able to select and interact with the text input